Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential out-of-bounds read (coverity) #844

Merged
merged 2 commits into from
Sep 21, 2016
Merged

Conversation

stweil
Copy link
Contributor

@stweil stweil commented Sep 18, 2016

Signed-off-by: Stefan Weil sw@weilnetz.de

CID 1190207 (uclouvain#1 of 1): Out-of-bounds read (OVERRUN)

Variable i must be checked before testing query_param.box_type.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
CID 1190206 (uclouvain#1 of 1): Out-of-bounds read (OVERRUN)

Variable i must be checked before testing query_param.box_type.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@stweil
Copy link
Contributor Author

stweil commented Sep 18, 2016

The last update for Coverity Scan was more than two years ago. An update would be really helpful.

@mayeut mayeut merged commit 045aa4d into uclouvain:master Sep 21, 2016
@mayeut
Copy link
Collaborator

mayeut commented Sep 21, 2016

@malaterre , you might wan't this in branch 2.1 for openjpip package

@stweil stweil deleted the coverity branch September 21, 2016 11:34
@stweil
Copy link
Contributor Author

stweil commented Sep 21, 2016

The last update for Coverity Scan was more than two years ago. An update would be really helpful.

I just noticed that there are two entries for OpenJPEG on Coverity Scan:

This is a little bit confusing.

@malaterre malaterre added this to the OPJ v2.1.2 milestone Sep 21, 2016
malaterre pushed a commit that referenced this pull request Sep 21, 2016
* query_parser: Fix potential out-of-bounds read (coverity)

CID 1190207 (#1 of 1): Out-of-bounds read (OVERRUN)

Variable i must be checked before testing query_param.box_type.

Signed-off-by: Stefan Weil <sw@weilnetz.de>

* jpip_parser: Fix potential out-of-bounds read (coverity)

CID 1190206 (#1 of 1): Out-of-bounds read (OVERRUN)

Variable i must be checked before testing query_param.box_type.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@mayeut
Copy link
Collaborator

mayeut commented Sep 21, 2016

@stweil, the one used by travis-ci is uclouvain-openjpeg . I think there was some problem with the old one at some point. Maybe @detonin has more info about this.

@detonin
Copy link
Contributor

detonin commented Sep 21, 2016

@stweil yes there was a bug on coverity website preventing to link the legacy account with the github repo so we add to create a new one. I should probably close the old one and invite people on uclouvain-openjpeg.

@detonin detonin added the bug label Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants